linux-kernel - Re: [PATCH net-next] bnxt_en: ethtool: Supply ntuple rss context action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241109092552.3295381d@kernel.org>
Date: Sat, 9 Nov 2024 09:25:52 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Xu <dxu@...uu.xyz>
Cc: michael.chan@...adcom.com, edumazet@...gle.com, davem@...emloft.net,
 andrew+netdev@...n.ch, pabeni@...hat.com, martin.lau@...ux.dev,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next] bnxt_en: ethtool: Supply ntuple rss context
 action

On Fri,  8 Nov 2024 12:07:29 -0700 Daniel Xu wrote:
> Commit 2f4f9fe5bf5f ("bnxt_en: Support adding ntuple rules on RSS
> contexts") added support for redirecting to an RSS context as an ntuple
> rule action. However, it forgot to update the ETHTOOL_GRXCLSRULE
> codepath. This caused `ethtool -n` to always report the action as
> "Action: Direct to queue 0" which is wrong.
> 
> Fix by teaching bnxt driver to report the RSS context when applicable.

Ah, so it was a driver bug after all.

Please add a fixes tag here, add a test case for this in
tools/testing/selftests/drivers/net/hw/rss_ctx.py
as a second patch of the series.
-- 
pw-bot: cr