lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <addc1303-c485-41dd-b31c-531b334b1d82@lunn.ch>
Date: Sat, 9 Nov 2024 18:55:07 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Sanman Pradhan <sanman.p211993@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	kernel-team@...a.com, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, horms@...nel.org, corbet@....net,
	mohsin.bashr@...il.com, sanmanpradhan@...a.com,
	andrew+netdev@...n.ch, vadim.fedorenko@...ux.dev,
	jdamato@...tly.com, sdf@...ichev.me, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] eth: fbnic: Add PCIe hardware statistics

> +static void fbnic_hw_stat_rst64(struct fbnic_dev *fbd, u32 reg, s32 offset,
> +				struct fbnic_stat_counter *stat)
> +{
> +	/* Record initial counter values and compute deltas from there to ensure
> +	 * stats start at 0 after reboot/reset. This avoids exposing absolute
> +	 * hardware counter values to userspace.

Now you are in debugfs, this convention from ethtool -S no longer
applies. You could simply this code a lot by exposing the absolute
values.

	Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ