linux-kernel - Re: [PATCH v4 1/3] landlock: Refactor filesystem access mask management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zy-rpxay3VmM7QuG@google.com>
Date: Sat, 9 Nov 2024 19:36:23 +0100
From: "Günther Noack" <gnoack@...gle.com>
To: "Mickaël Salaün" <mic@...ikod.net>
Cc: Mikhail Ivanov <ivanov.mikhail1@...wei-partners.com>, 
	Konstantin Meskhidze <konstantin.meskhidze@...wei.com>, Paul Moore <paul@...l-moore.com>, 
	Tahera Fahimi <fahimitahera@...il.com>, linux-kernel@...r.kernel.org, 
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH v4 1/3] landlock: Refactor filesystem access mask management

On Sat, Nov 09, 2024 at 12:14:49PM +0100, Mickaël Salaün wrote:
> On Sat, Nov 09, 2024 at 12:08:54PM +0100, Mickaël Salaün wrote:
> > Replace get_raw_handled_fs_accesses() with a generic
> > landlock_merge_access_masks(), and replace get_fs_domain() with a
> > generic landlock_match_ruleset().  These helpers will also be useful for
> > other types of access.
> 
> Of course I need to update the commit messages with the new names...

Yes, those are still using the old function names.

At this point my other two remaining remarks are so minor,
I think we can skip another version of this patch set. 👍

Thanks for simplifying the code!

—Günther