[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNATED9GeR_0DP_nrqahLOrz_4gwB0X9hm5gBVta4oyBrog@mail.gmail.com>
Date: Sun, 10 Nov 2024 07:20:47 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Thomas Böhler <t.boehler@...bus.com>
Cc: Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org,
linux-kernel@...r.kernel.org, Philipp Rosenberger <p.rosenberger@...bus.com>,
Lino Sanfilippo <l.sanfilippo@...bus.com>
Subject: Re: [PATCH 2/3] package: debian: add missing Depends to linux-headers
Please use "kbuild: deb-pkg:" as the commit subject.
On Thu, Oct 31, 2024 at 10:26 PM Thomas Böhler <t.boehler@...bus.com> wrote:
>
> The linux-headers package is missing a dependency to libc. Lintian
> complains about this as well:
>
> W: linux-headers-6.12.0-rc4-g7e04fcfc6195: undeclared-elf-prerequisites (libc.so.6) [usr/src/linux-headers-6.12.0-rc4-g7e04fcfc6195/scripts/asn1_compiler]
> W: linux-headers-6.12.0-rc4-g7e04fcfc6195: undeclared-elf-prerequisites (libc.so.6) [usr/src/linux-headers-6.12.0-rc4-g7e04fcfc6195/scripts/basic/fixdep]
> W: linux-headers-6.12.0-rc4-g7e04fcfc6195: undeclared-elf-prerequisites (libc.so.6) [usr/src/linux-headers-6.12.0-rc4-g7e04fcfc6195/scripts/kallsyms]
> W: linux-headers-6.12.0-rc4-g7e04fcfc6195: undeclared-elf-prerequisites (libc.so.6) [usr/src/linux-headers-6.12.0-rc4-g7e04fcfc6195/scripts/mod/modpost]
> W: linux-headers-6.12.0-rc4-g7e04fcfc6195: undeclared-elf-prerequisites (libc.so.6) [usr/src/linux-headers-6.12.0-rc4-g7e04fcfc6195/scripts/sorttable]
Could you add log messages based on linux-headers-6.12.0-rc6 instead?
Then, the line length will become shorter.
Also, please rebase this on the mainline.
> Fix this by introducing "dh_shlibdeps" into the build process. It
> calculates shared library dependencies for packages and creates a
> substvar entry for them, making them usable in "debian/control" by
> specifying "${shlibs:Depends}" in the "Depends" field.
>
> "dh_shlibdeps" detects the dependency on libc for the linux-headers
> package and by specifying the substvar for the linux-headers package in
> "debian/control" this dependency is correctly declared and lintian won't
> complain about it anymore.
>
> Signed-off-by: Thomas Böhler <t.boehler@...bus.com>
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists