linux-kernel - Re: [PATCH 19/23] kbuild: support building external modules in a separate build directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATpKk28mx5Au6pge-uAJCwqkQHdUXKNTDs-QQj6bOoeFQ@mail.gmail.com>
Date: Sun, 10 Nov 2024 10:36:32 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Nicolas Schier <nicolas@...sle.eu>
Cc: linux-kbuild@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH 19/23] kbuild: support building external modules in a
 separate build directory

On Sat, Oct 5, 2024 at 4:45 AM Nicolas Schier <nicolas@...sle.eu> wrote:

> > > @@ -640,6 +648,7 @@ quiet_cmd_makefile = GEN     Makefile
> > >     } > Makefile
> > >
> > >  outputmakefile:
> > > +ifeq ($(KBUILD_EXTMOD),)
> > >     @if [ -f $(srctree)/.config -o \
> > >              -d $(srctree)/include/config -o \
> > >              -d $(srctree)/arch/$(SRCARCH)/include/generated ]; then \
> > > @@ -649,7 +658,16 @@ outputmakefile:
> > >             echo >&2 "***"; \
> > >             false; \
> > >     fi
> > > -   $(Q)ln -fsn $(srctree) source
> > > +else
> > > +   @if [ -f $(KBUILD_EXTMOD)/modules.order ]; then \
>
> If I do
>
>     make O=build
>     touch fs/btrfs/modules.order
>     make O=build M=fs/btrfs/ MO=/tmp/btrfs CONFIG_BTRFS_FS=m
>
> the 'modules.order' check does not work correctly.  But a consequtive
>
>     make -C /tmp/btrfs CONFIG_BTRFS_FS=m
>
> shows the 'The external module source tree is not clean.' message as
> expected.
>
> If I replace $(KBUILD_EXTMOD) by $(abs_extmodtree), it works for me also
> in the first case.

Right, this check does not work correctly
when KBUILD_EXTMOD is a relative path.

In v2, I changed this part.



--
Best Regards
Masahiro Yamada