linux-kernel - Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72688d81-24db-70ba-e260-bd5c74066d27@google.com>
Date: Sat, 9 Nov 2024 18:19:28 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Joshua Hahn <joshua.hahnjy@...il.com>
cc: akpm@...ux-foundation.org, hannes@...xchg.org, nphamcs@...il.com, 
    shakeel.butt@...ux.dev, roman.gushchin@...ux.dev, muchun.song@...ux.dev, 
    chris@...isdown.name, tj@...nel.org, lizefan.x@...edance.com, 
    mkoutny@...e.com, corbet@....net, lnyng@...a.com, cgroups@...r.kernel.org, 
    linux-mm@...ck.org, linux-doc@...r.kernel.org, 
    linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg

On Fri, 1 Nov 2024, Joshua Hahn wrote:

> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 69af2173555f..bd7e81c2aa2b 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1646,6 +1646,11 @@ The following nested keys are defined.
>  	  pgdemote_khugepaged
>  		Number of pages demoted by khugepaged.
>  
> +	  hugetlb
> +		Amount of memory used by hugetlb pages. This metric only shows
> +		up if hugetlb usage is accounted for in memory.current (i.e.
> +		cgroup is mounted with the memory_hugetlb_accounting option).
> +
>    memory.numa_stat
>  	A read-only nested-keyed file which exists on non-root cgroups.
>  

Definitely makes sense to include this.

Any reason to not account different hugetlb page sizes separately in this 
stat, however?  IOW, should there be separate hugetlb_2048kB and 
hugetlb_1048576kB stats on x86?