linux-kernel - Re: [PATCH v1 1/2] gpio: mpfs: add CoreGPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MeVHx9u0oDT-cgRir474owqwPMzgBiPW9jFRbdYjnXbhQ@mail.gmail.com>
Date: Sun, 10 Nov 2024 20:08:20 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Conor Dooley <conor@...nel.org>
Cc: linux-gpio@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>, 
	Daire McNamara <daire.mcnamara@...rochip.com>, Linus Walleij <linus.walleij@...aro.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] gpio: mpfs: add CoreGPIO support

On Thu, Nov 7, 2024 at 11:33 AM Conor Dooley <conor@...nel.org> wrote:
>
> From: Conor Dooley <conor.dooley@...rochip.com>
>
> coreGPIO, which the "hard" core in PolarFire SoC is based on, has
> different offsets for inp/outp. Add some match_data handling to account
> for the differences.
>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>  drivers/gpio/gpio-mpfs.c | 38 +++++++++++++++++++++++++++++++++-----
>  1 file changed, 33 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mpfs.c b/drivers/gpio/gpio-mpfs.c
> index 3718121eb97a..4aefae05a9fb 100644
> --- a/drivers/gpio/gpio-mpfs.c
> +++ b/drivers/gpio/gpio-mpfs.c
> @@ -10,6 +10,7 @@
>  #include <linux/errno.h>
>  #include <linux/gpio/driver.h>
>  #include <linux/init.h>
> +#include <linux/of_device.h>

You don't need this. Include property.h and use device_get_match_data() instead.

Bart