linux-kernel - Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241109223436.3ddeaf1d60e1ade8f562d757@linux-foundation.org>
Date: Sat, 9 Nov 2024 22:34:36 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Muhammad Usama Anjum <Usama.Anjum@...labora.com>, Donet Tom
 <donettom@...ux.ibm.com>, Shuah Khan <shuah@...nel.org>,
 kernel@...labora.com, linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to
 skip in the start

On Sat, 9 Nov 2024 22:20:01 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Fri, 8 Nov 2024 19:13:04 +0500 Muhammad Usama Anjum <Usama.Anjum@...labora.com> wrote:
> 
> > On 11/8/24 3:49 PM, Donet Tom wrote:
> > 
> > > I think below changes are required.
> > > 
> > > iff --git a/tools/testing/selftests/mm/hugetlb_dio.c b/tools/testing/selftests/mm/hugetlb_dio.c
> > > index 60001c142ce9..4b52106b8124 100644
> > > --- a/tools/testing/selftests/mm/hugetlb_dio.c
> > > +++ b/tools/testing/selftests/mm/hugetlb_dio.c
> > > @@ -44,6 +44,9 @@ void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off)
> > >         if (fd < 0)
> > >                 ksft_exit_fail_perror("Error opening file\n");
> > >  
> > > +       /* Get the free huge pages before allocation */
> > > +       free_hpage_b = get_free_hugepages();
> > > +
> > >         /* Allocate a hugetlb page */
> > > 
> > >         orig_buffer = mmap(NULL, h_pagesize, mmap_prot, mmap_flags, -1, 0);
> > > 
> > >         if (orig_buffer == MAP_FAILED) {
> > Please can you send a fixup patch as you have working test setup?
> > Otherwise I'll take it up and try to test on working setup before
> > posting the fixup patch. Please let me know.
> 
> I've removed this patch from mm-hotfixes-stable.

I changed my mind.  Please send any fixup against the previous patch.