linux-kernel - Re: [PATCH v2 4/6] media: uvcvideo: Create ancillary link for GPIO subdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzCFfnTVgvY7vURV@valkosipuli.retiisi.eu>
Date: Sun, 10 Nov 2024 10:05:50 +0000
From: Sakari Ailus <sakari.ailus@....fi>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	Yunke Cao <yunkec@...omium.org>, Hans Verkuil <hverkuil@...all.nl>,
	Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v2 4/6] media: uvcvideo: Create ancillary link for GPIO
 subdevice

Hi Ricardo,

On Fri, Nov 08, 2024 at 08:25:48PM +0000, Ricardo Ribalda wrote:
> Make an ancillary device between the streaming subdevice and the GPIO

s/device/link/

> subdevice.

Either subdev or sub-device. Same above.

> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
>  drivers/media/usb/uvc/uvc_entity.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_entity.c b/drivers/media/usb/uvc/uvc_entity.c
> index c1b69f9eaa56..dad77b96fe16 100644
> --- a/drivers/media/usb/uvc/uvc_entity.c
> +++ b/drivers/media/usb/uvc/uvc_entity.c
> @@ -53,6 +53,16 @@ static int uvc_mc_create_links(struct uvc_video_chain *chain,
>  			return ret;
>  	}
>  
> +	/* Create ancillary link for the GPIO. */
> +	if (chain->dev->gpio_unit && UVC_ENTITY_TYPE(entity) == UVC_ITT_CAMERA) {

This seems to be over 80 for no apparent reason.

> +		struct media_link *link;
> +
> +		link = media_create_ancillary_link(sink,
> +					&chain->dev->gpio_unit->subdev.entity);

And following the alignment rules would push this over 80. I have no
problem with that.

> +		if (IS_ERR(link))
> +			return PTR_ERR(link);
> +	}
> +
>  	return 0;
>  }
>  
> 

-- 
Regards,

Sakari Ailus