linux-kernel - Re: [PATCH 2/4] kselftest/arm64: Use a define for SVCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzKUaqv_K-MRTti4@arm.com>
Date: Mon, 11 Nov 2024 23:34:02 +0000
From: Catalin Marinas <catalin.marinas@....com>
To: Mark Brown <broonie@...nel.org>
Cc: Will Deacon <will@...nel.org>, Shuah Khan <shuah@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 2/4] kselftest/arm64: Use a define for SVCR

On Thu, Nov 07, 2024 at 01:38:05AM +0000, Mark Brown wrote:
> For some reason when we're accessing SVCR in the FP tests we use the raw
> numerical version of the register name rather than hiding that behind a
> preprocessor macro for readability. Since we already use the generated
> defines for sysreg bitfields in other the KVM selftests let's do the same
> thing here, also replacing the defines for the SVCR bitfields which we
> have.
> 
> The build setup for fp-ptrace is a little fun so we have to manually define
> __ASSEMBLY__ in the source code for that.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

I get an error when trying to build this out of tree:

/home/cmarinas/work/linux/tools/testing/selftests/../../../tools/arch/arm64/include/asm/sysreg.h:132:10: fatal error: asm/sysreg-defs.h: No such file or directory
  132 | #include "asm/sysreg-defs.h"
      |          ^~~~~~~~~~~~~~~~~~~

Probably sysreg-defs.h has not been generated yet. Too late to figure it
out now.

-- 
Catalin