linux-kernel - RE: [PATCH] cdx: Fix cdx_mmap_resource() after constifying attr in ->mmap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB5333396F89AC0F08DEB947CE9D582@BL1PR12MB5333.namprd12.prod.outlook.com>
Date: Mon, 11 Nov 2024 11:06:15 +0000
From: "Agarwal, Nikhil" <nikhil.agarwal@....com>
To: Nathan Chancellor <nathan@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>
CC: Thomas Weißschuh <linux@...ssschuh.net>, "Gupta,
 Nipun" <Nipun.Gupta@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>
Subject: RE: [PATCH] cdx: Fix cdx_mmap_resource() after constifying attr in
 ->mmap()


> 
> Commit 94a20fb9af16 ("sysfs: treewide: constify attribute callback of
> bin_attribute::mmap()") missed updating the attr parameter of
> cdx_mmap_resource(), resulting in a build failure.
> 
>   drivers/cdx/cdx.c: In function 'cdx_create_res_attr':
>   drivers/cdx/cdx.c:773:24: error: assignment to 'int (*)(struct file *, struct kobject *,
> const struct bin_attribute *, struct vm_area_struct *)' from incompatible pointer type
> 'int (*)(struct file *, struct kobject *, struct bin_attribute *, struct vm_area_struct *)' [-
> Wincompatible-pointer-types]
>     773 |         res_attr->mmap = cdx_mmap_resource;
>         |                        ^
> 
> Update cdx_mmap_resource() to match, resolving the build failure.
> 
> Fixes: 94a20fb9af16 ("sysfs: treewide: constify attribute callback of
> bin_attribute::mmap()")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
Acked-by: Nikhil Agarwal <nikhil.agarwal@....com>