linux-kernel - Re: [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d546a5b-b56b-359c-5dae-4cb1cfd0f535@linux.intel.com>
Date: Mon, 11 Nov 2024 10:38:54 +0800
From: Bingbu Cao <bingbu.cao@...ux.intel.com>
To: Yang Li <yang.lee@...ux.alibaba.com>, sakari.ailus@...ux.intel.com,
 bingbu.cao@...el.com, tian.shu.qiu@...el.com, mchehab@...nel.org
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] media: ipu6: Remove duplicated include in
 ipu6-dma.h


On 11/11/24 10:12 AM, Bingbu Cao wrote:
> Li,
> 
> Thanks for the patch.
> 
> On 11/11/24 9:56 AM, Yang Li wrote:
>> The header files linux/iova.h is included twice in ipu6-dma.h,
>> so one inclusion of each can be removed.
>>
>> ./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more
>> than once.
>>
>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11791
> 
> It'd better to add:
> Fixes: 799d91fd3fe0 ("media: ipu6: not override the dma_ops of device in driver")

Oops, I just noticed the commit above is on the road...
You can correct the hash after it is applied.

> 
>> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
>> ---
>>  drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> index b51244add9e6..a902eec5c07a 100644
>> --- a/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h
>> @@ -7,7 +7,6 @@
>>  #include <linux/dma-map-ops.h>
>>  #include <linux/dma-mapping.h>
>>  #include <linux/iova.h>
>> -#include <linux/iova.h>
>>  #include <linux/scatterlist.h>
>>  #include <linux/types.h>
>>  
>>
> 
> Reviewed-by: Bingbu Cao <bingbu.cao@...el.com>
> 
> 

-- 
Best regards,
Bingbu Cao