linux-kernel - Re: [PATCH v2 3/3] kselftest/arm64: Add FPMR coverage to fp-ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzNaOSjRrO5bAJ46@finisterre.sirena.org.uk>
Date: Tue, 12 Nov 2024 13:38:01 +0000
From: Mark Brown <broonie@...nel.org>
To: Catalin Marinas <catalin.marinas@....com>
Cc: Will Deacon <will@...nel.org>, Shuah Khan <shuah@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 3/3] kselftest/arm64: Add FPMR coverage to fp-ptrace

On Tue, Nov 12, 2024 at 01:26:52PM +0000, Catalin Marinas wrote:
> On Tue, Nov 12, 2024 at 01:08:16PM +0000, Mark Brown wrote:
> > +	// This has to come after we set PSTATE.SM
> > +check_fpmr_in:
> > +	tbz	x0, #HAVE_FPMR_SHIFT, wait_for_writes
> > +	adrp	x7, fpmr_in
> > +	ldr	x7, [x7, :lo12:fpmr_in]
> > +	msr	FPMR, x7

> Did this build for you? I may not have a new enough assembler.

Yes, it even ran through tests.  I suspect it's picking up some
(possibly stale generated?) header file which has the FPMR define in it.

> fp-ptrace-asm.S:149:6: error: expected writable system register or pstate
>  msr FPMR, x7

> I changed it to REG_FPMR locally.

Thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)