linux-kernel - Re: [PATCH][next] security: remove redundant assignment to variable rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241112133224.GA340871@mail.hallyn.com>
Date: Tue, 12 Nov 2024 07:32:24 -0600
From: "Serge E. Hallyn" <serge@...lyn.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
	"Serge E . Hallyn" <serge@...lyn.com>,
	linux-security-module@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] security: remove redundant assignment to variable
 rc

On Tue, Nov 12, 2024 at 12:45:32PM +0000, Colin Ian King wrote:
> In the case where rc is equal to EOPNOTSUPP it is being reassigned a
> new value of zero that is never read. The following continue statement
> loops back to the next iteration of the lsm_for_each_hook loop and
> rc is being re-assigned a new value from the call to getselfattr.
> The assignment is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Serge Hallyn <serge@...lyn.com>

(long as it doesn't go to stable :)

> ---
>  security/security.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/security/security.c b/security/security.c
> index 09664e09fec9..6147f27ea92a 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -4139,10 +4139,8 @@ int security_getselfattr(unsigned int attr, struct lsm_ctx __user *uctx,
>  		if (base)
>  			uctx = (struct lsm_ctx __user *)(base + total);
>  		rc = scall->hl->hook.getselfattr(attr, uctx, &entrysize, flags);
> -		if (rc == -EOPNOTSUPP) {
> -			rc = 0;
> +		if (rc == -EOPNOTSUPP)
>  			continue;
> -		}
>  		if (rc == -E2BIG) {
>  			rc = 0;
>  			left = 0;
> -- 
> 2.39.5