linux-kernel - Re: [PATCH] scsi: target: tcmu: Constify some structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e01952e3-8098-4490-a813-ed0d9457eb3e@gmail.com>
Date: Tue, 12 Nov 2024 14:49:55 +0100
From: Bodo Stroesser <bostroesser@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-scsi@...r.kernel.org, target-devel@...r.kernel.org
Subject: Re: [PATCH] scsi: target: tcmu: Constify some structures

On 11.11.24 14:10, Christophe JAILLET wrote:
> 'struct nla_policy' and 'struct match_table_t' are not modified in this
> driver.
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers, which is the case of struct nla_policy.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>     text	   data	    bss	    dec	    hex	filename
>    93188	   6933	    338	 100459	  1886b	drivers/target/target_core_user.o
> 
> After:
> =====
>     text	   data	    bss	    dec	    hex	filename
>    93508	   6581	    338	 100427	  1884b	drivers/target/target_core_user.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only
> ---
>   drivers/target/target_core_user.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 717931267bda..0f5d820af119 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -361,7 +361,7 @@ static const struct genl_multicast_group tcmu_mcgrps[] = {
>   	[TCMU_MCGRP_CONFIG] = { .name = "config", },
>   };
>   
> -static struct nla_policy tcmu_attr_policy[TCMU_ATTR_MAX+1] = {
> +static const struct nla_policy tcmu_attr_policy[TCMU_ATTR_MAX + 1] = {
>   	[TCMU_ATTR_DEVICE]	= { .type = NLA_STRING },
>   	[TCMU_ATTR_MINOR]	= { .type = NLA_U32 },
>   	[TCMU_ATTR_CMD_STATUS]	= { .type = NLA_S32 },
> @@ -2430,7 +2430,7 @@ enum {
>   	Opt_cmd_ring_size_mb, Opt_err,
>   };
>   
> -static match_table_t tokens = {
> +static const match_table_t tokens = {
>   	{Opt_dev_config, "dev_config=%s"},
>   	{Opt_dev_size, "dev_size=%s"},
>   	{Opt_hw_block_size, "hw_block_size=%d"},


Reviewed-by: Bodo Stroesser <bostroesser@...il.com>

Thanks,
Bodo