linux-kernel - Re: [PATCHv3 net 1/2] bonding: add ns target multicast address to slave device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6821f3d4-3157-451d-86f2-bb1d1a990c17@blackwall.org>
Date: Tue, 12 Nov 2024 15:50:22 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>,
 Andy Gospodarek <andy@...yhouse.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 net 1/2] bonding: add ns target multicast address to
 slave device

On 11/11/24 12:05, Hangbin Liu wrote:
> On Wed, Nov 06, 2024 at 12:25:10PM +0200, Nikolay Aleksandrov wrote:
>>> diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
>>> index 95d59a18c022..60368cef2704 100644
>>> --- a/drivers/net/bonding/bond_options.c
>>> +++ b/drivers/net/bonding/bond_options.c
>>> @@ -15,6 +15,7 @@
>>>  #include <linux/sched/signal.h>
>>>  
>>>  #include <net/bonding.h>
>>> +#include <net/ndisc.h>
>>>  
>>>  static int bond_option_active_slave_set(struct bonding *bond,
>>>  					const struct bond_opt_value *newval);
>>> @@ -1234,6 +1235,64 @@ static int bond_option_arp_ip_targets_set(struct bonding *bond,
>>>  }
>>>  
>>>  #if IS_ENABLED(CONFIG_IPV6)
>>> +static bool slave_can_set_ns_maddr(struct bonding *bond, struct slave *slave)
>>
>> const bond/slave
>>
>>> +{
>>> +	return BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP &&
>>> +	       !bond_is_active_slave(slave) &&
>>> +	       slave->dev->flags & IFF_MULTICAST;
>>> +}
> 
> Hi, FYI, in new patch I only set bond to const as slave will be called
> by bond_is_active_slave().
> 
> Thanks
> Hangbin

Yeah, I figured. :) Thanks for letting me know!