linux-kernel - Re: [PATCH] ASoC: da7219-aad: Fix detection of plugged jack after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzNVH65o0ue6jn6a@finisterre.sirena.org.uk>
Date: Tue, 12 Nov 2024 13:16:15 +0000
From: Mark Brown <broonie@...nel.org>
To: Marek Maslanka <mmaslanka@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
	Support Opensource <support.opensource@...semi.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org
Subject: Re: [PATCH] ASoC: da7219-aad: Fix detection of plugged jack after
 resume

On Tue, Nov 12, 2024 at 07:40:47AM +0000, Marek Maslanka wrote:
> Don't notify and mark the jack as unplugged during the "set_jack" action,
> because this action is called very late in during the resume process, forcing
> the jack to be unplugged after the resume, even if the jack is plugged in. Let's
> leave the responsibility of managing the insertion of the jack to IRQ.

> @@ -33,10 +33,6 @@ void da7219_aad_jack_det(struct snd_soc_component *component, struct snd_soc_jac
>  	struct da7219_priv *da7219 = snd_soc_component_get_drvdata(component);
>  
>  	da7219->aad->jack = jack;
> -	da7219->aad->jack_inserted = false;
> -
> -	/* Send an initial empty report */
> -	snd_soc_jack_report(jack, 0, DA7219_AAD_REPORT_ALL_MASK);
>  
>  	/* Enable/Disable jack detection */
>  	snd_soc_component_update_bits(component, DA7219_ACCDET_CONFIG_1,

This path is also (AFAICT only?) called when registering the jack by
da7219_set_jack(), I'm not immediately seeing the path for resume.  This
suggests that what's going on here is an issue with the machine driver
unregistering the jack over suspend?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)