linux-kernel - Re: [PATCH v8 net-next 3/4] ipv4/udp: Add 4-tuple hash for connected socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1db0c11-38ee-4932-86bc-a397a0ecf963@redhat.com>
Date: Tue, 12 Nov 2024 15:58:05 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Philo Lu <lulie@...ux.alibaba.com>, netdev@...r.kernel.org
Cc: willemdebruijn.kernel@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, dsahern@...nel.org, horms@...nel.org,
 antony.antony@...unet.com, steffen.klassert@...unet.com,
 linux-kernel@...r.kernel.org, dust.li@...ux.alibaba.com,
 jakub@...udflare.com, fred.cc@...baba-inc.com,
 yubing.qiuyubing@...baba-inc.com
Subject: Re: [PATCH v8 net-next 3/4] ipv4/udp: Add 4-tuple hash for connected
 socket

On 11/8/24 06:48, Philo Lu wrote:
[...]
> Signed-off-by: Philo Lu <lulie@...ux.alibaba.com>
> Signed-off-by: Cambda Zhu <cambda@...ux.alibaba.com>
> Signed-off-by: Fred Chen <fred.cc@...baba-inc.com>
> Signed-off-by: Yubing Qiu <yubing.qiuyubing@...baba-inc.com>

[...]
> @@ -2937,7 +3128,7 @@ struct proto udp_prot = {
>  	.owner			= THIS_MODULE,
>  	.close			= udp_lib_close,
>  	.pre_connect		= udp_pre_connect,
> -	.connect		= ip4_datagram_connect,
> +	.connect		= udp_connect,
>  	.disconnect		= udp_disconnect,
>  	.ioctl			= udp_ioctl,
>  	.init			= udp_init_sock,

2 minor notes, possibly not needing a repost:

- The SoB chain looks strange, do you mean co-developed-by actually?
- udplite is not touched. AFAICS should not be a problem - just the
feature will not be available for udplite. I'm wondering if syzbot could
prove me wrong about "not being a problem" (usually it's able to do that;)

/P