linux-kernel - Re: [PATCH v4 6/6] rust: add improved version of `ForeignOwnable::borrow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9k7rLo-QkTdQwrQ743-VAVfjzNKMhoCqmDjUHr=cOB+UQ@mail.gmail.com>
Date: Tue, 12 Nov 2024 10:20:41 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Martin Rodriguez Reboredo <yakoyoku@...il.com>
Subject: Re: [PATCH v4 6/6] rust: add improved version of `ForeignOwnable::borrow_mut`

On Mon, Nov 11, 2024 at 7:02 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Mon, Nov 11, 2024 at 5:22 PM Tamir Duberstein <tamird@...il.com> wrote:
> >
> > My reading of that discussion is that the new `crate::ffi` module
> > isn't going anywhere, it's just the later patches that diverge the
> > types that might be dropped for now and taken later.
>
> Yeah, that was my plan, and I ended up with that.
>
> However, we still need to see how it actually goes -- we will see tomorrow.
>
> > In my case though I have a hard conflict as the patch introducing
> > `crate::ffi` and this series touch the same lines so I think a rebase
> > is unavoidable.
>
> If there are conflicts, then a new version is usually welcome, unless
> the conflict is small or trivial (i.e. sometimes maintainers may do
> the rebase for you and other adjustments -- a new version may not be
> worth it, and it depends on the maintainer).

The conflict is trivial here, but I've already done the rebase 🤷🏼‍♂️.

> In this case, please wait a few days to see if you get more feedback,
> and meanwhile the linux-next issue will be resolved one way or
> another, so you can use whatever is in rust-next by then.

Will do! Thanks Miguel.