linux-kernel - Re: [PATCH] drm/msm/a5xx: Fix dereference of pointer pdev before null check on pdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34bc44c2-e1d2-4610-8a87-f20078592e7e@gmail.com>
Date: Tue, 12 Nov 2024 16:28:19 +0100
From: Konrad Dybcio <konradybcio@...il.com>
To: Colin Ian King <colin.i.king@...il.com>, Rob Clark <robdclark@...il.com>,
 Sean Paul <sean@...rly.run>, Konrad Dybcio <konradybcio@...nel.org>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm/a5xx: Fix dereference of pointer pdev before null
 check on pdev



On 11/12/24 14:20, Colin Ian King wrote:
> The pointer config is dereferencing pointer pdev before pdev is null
> checked, this could lead to a potential null pointer dereference on pdev.
> Fix this by only assinging config after pdev has been null checked.
> 
> Fixes: 736a93273656 ("drm/msm/a5xx: really check for A510 in a5xx_gpu_init")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---

I'd rather drop this check, the only call chain is rather
safe here

Konrad