linux-kernel - Re: [PATCH 1/5] scsi: ufs: core: Cancel RTC work during ufshcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <183b7ba041d1b271bdf36ea969381be704633052.camel@mediatek.com>
Date: Tue, 12 Nov 2024 02:13:39 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "linkinjeon@...il.com" <linkinjeon@...il.com>, "orsonzhai@...il.com"
	<orsonzhai@...il.com>, "baolin.wang@...ux.alibaba.com"
	<baolin.wang@...ux.alibaba.com>, "yoshihiro.shimoda.uh@...esas.com"
	<yoshihiro.shimoda.uh@...esas.com>, "mikebi@...ron.com" <mikebi@...ron.com>,
	"krzk@...nel.org" <krzk@...nel.org>, "lporzio@...ron.com"
	<lporzio@...ron.com>, "linux@...ssschuh.net" <linux@...ssschuh.net>,
	"beanhuo@...ron.com" <beanhuo@...ron.com>, "avri.altman@....com"
	<avri.altman@....com>, "bvanassche@....org" <bvanassche@....org>,
	"zhang.lyra@...il.com" <zhang.lyra@...il.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "quic_asutoshd@...cinc.com"
	<quic_asutoshd@...cinc.com>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "chu.stanley@...il.com"
	<chu.stanley@...il.com>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "pedrom.sousa@...opsys.com"
	<pedrom.sousa@...opsys.com>, "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"santoshsy@...il.com" <santoshsy@...il.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/5] scsi: ufs: core: Cancel RTC work during
 ufshcd_remove()

On Mon, 2024-11-11 at 23:18 +0530, Manivannan Sadhasivam via B4 Relay
wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> Currently, RTC work is only cancelled during __ufshcd_wl_suspend().
> When
> ufshcd is removed in ufshcd_remove(), RTC work is not cancelled. Due
> to
> this, any further trigger of the RTC work after ufshcd_remove() would
> result in a NULL pointer dereference as below:
> 
> Unable to handle kernel NULL pointer dereference at virtual address
> 00000000000002a4
> Workqueue: events ufshcd_rtc_work
> Call trace:
>  _raw_spin_lock_irqsave+0x34/0x8c
>  pm_runtime_get_if_active+0x24/0xb4
>  ufshcd_rtc_work+0x124/0x19c
>  process_scheduled_works+0x18c/0x2d8
>  worker_thread+0x144/0x280
>  kthread+0x11c/0x128
>  ret_from_fork+0x10/0x20
> 
> Since RTC work accesses the ufshcd internal structures, it should be
> cancelled
> when ufshcd is removed. So do that in ufshcd_remove(), as per the
> order in
> ufshcd_init().
> 
> Cc: stable@...r.kernel.org # 6.8
> Fixes: 6bf999e0eb41 ("scsi: ufs: core: Add UFS RTC support")
> Signed-off-by: Manivannan Sadhasivam <
> manivannan.sadhasivam@...aro.org>
> ---
>  drivers/ufs/core/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>