linux-kernel - Re: [PATCH v3 2/2] rtc: pcf2127: Add 'nxp,battery-switchover' DT property to enable battery switch-over

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241112163840.GA1151895-robh@kernel.org>
Date: Tue, 12 Nov 2024 10:38:40 -0600
From: Rob Herring <robh@...nel.org>
To: Philipp Rosenberger <p.rosenberger@...bus.com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Lino Sanfilippo <l.sanfilippo@...bus.com>,
	Thomas Böhler <t.boehler@...bus.com>,
	Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH v3 2/2] rtc: pcf2127: Add 'nxp,battery-switchover' DT
 property to enable battery switch-over

On Mon, Nov 11, 2024 at 04:41:44PM +0100, Philipp Rosenberger wrote:
> The PCF2127, PCF2129, and PCA2129 RTCs have the battery switch-over function
> enabled by default. However, the newer PCF2131 RTC has the opposite default
> behavior, requiring explicit enablement for battery backup.

Subject is wrong.

> 
> Add support for the `nxp,battery-backed` device tree property to enable battery
> switch-over in standard mode for the rtc-pcf2127 driver. If this property is set
> and no battery switch-over mode is already configured, the driver will enable
> standard mode; otherwise, existing configurations remain unchanged.
> 
> Signed-off-by: Philipp Rosenberger <p.rosenberger@...bus.com>
> ---
>  drivers/rtc/rtc-pcf2127.c | 76 +++++++++++++++++++++++++++++++--------
>  1 file changed, 61 insertions(+), 15 deletions(-)