linux-kernel - Re: [PATCH RESEND v9 2/2] drm/amdgpu: Enable async flip on overlay planes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0829825f-6e6e-465e-aa3c-444d57bd115e@igalia.com>
Date: Tue, 12 Nov 2024 13:44:43 -0300
From: André Almeida <andrealmeid@...lia.com>
To: Harry Wentland <harry.wentland@....com>
Cc: kernel-dev@...lia.com, Daniel Stone <daniel@...ishbar.org>,
 Xaver Hugl <xaver.hugl@...il.com>, Christian König
 <christian.koenig@....com>, David Airlie <airlied@...il.com>,
 Xinhui Pan <Xinhui.Pan@....com>, joshua@...ggi.es,
 Leo Li <sunpeng.li@....com>, Maxime Ripard <mripard@...nel.org>,
 Simon Ser <contact@...rsion.fr>, dmitry.baryshkov@...aro.org,
 Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 amd-gfx@...ts.freedesktop.org, ville.syrjala@...ux.intel.com,
 Alex Deucher <alexander.deucher@....com>,
 Thomas Zimmermann <tzimmermann@...e.de>, Simona Vetter <simona@...ll.ch>
Subject: Re: [PATCH RESEND v9 2/2] drm/amdgpu: Enable async flip on overlay
 planes

Hi Harry, thanks for the reply!

Em 11/11/2024 18:10, Harry Wentland escreveu:
> On 2024-11-01 14:23, André Almeida wrote:
>> amdgpu can handle async flips on overlay planes, so allow it for atomic
>> async checks.
>>
>> Signed-off-by: André Almeida <andrealmeid@...lia.com>
>> ---
>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> index 495e3cd70426db0182cb2811bc6d5d09f52f8a4b..4c6aed5ca777d76245f5f2865046f0f598be342a 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> @@ -1266,8 +1266,7 @@ static int amdgpu_dm_plane_atomic_async_check(struct drm_plane *plane,
>>   	struct drm_plane_state *new_plane_state;
>>   	struct dm_crtc_state *dm_new_crtc_state;
>>   
>> -	/* Only support async updates on cursor planes. */
>> -	if (plane->type != DRM_PLANE_TYPE_CURSOR)
>> +	if (plane->type != DRM_PLANE_TYPE_CURSOR && plane->type != DRM_PLANE_TYPE_OVERLAY)
> 
> This wouldn't just be called for flips, though, but could also be
> called for updates on a plane, right? Those could cause for problems.
> 

I see, I think you are right and can be called from a non-flip commmit.

> There's also nothing special about OVERLAY vs PRIMARY planes, other
> than that amdgpu needs a PRIMARY plane, IIRC. So updates on PRIMARY
> planes should also work (or not).
> 

Right, the PRIMARY plane type is already supported for every DRM driver 
in the API so I didn't explicitly added it here.

> Maybe this should check that we're actually dealing with a simple
> flip, i.e., a simple surface address update.
> 

Right, that makes sense to me, thanks!

> Harry
> 
>>   		return -EINVAL;
>>   
>>   	new_plane_state = drm_atomic_get_new_plane_state(state, plane);
>>
>