linux-kernel - Re: [PATCH] ASoC: da7219-aad: Fix detection of plugged jack after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzNqUrlCjvusuDbn@finisterre.sirena.org.uk>
Date: Tue, 12 Nov 2024 14:46:42 +0000
From: Mark Brown <broonie@...nel.org>
To: Marek Maślanka <mmaslanka@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
	Support Opensource <support.opensource@...semi.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org
Subject: Re: [PATCH] ASoC: da7219-aad: Fix detection of plugged jack after
 resume

On Tue, Nov 12, 2024 at 03:11:07PM +0100, Marek Maślanka wrote:
> On Tue, Nov 12, 2024 at 2:16 PM Mark Brown <broonie@...nel.org> wrote:

> > This path is also (AFAICT only?) called when registering the jack by
> > da7219_set_jack(), I'm not immediately seeing the path for resume.  This
> > suggests that what's going on here is an issue with the machine driver
> > unregistering the jack over suspend?

> In my case the da7219_set_jack() is directly called from avs_card_resume_post()
> (sound/soc/intel/avs/boards/da7219.c) so that could be a problem too.

Right, that's the machine driver unregistering the jack over suspend
thing that I mentioned.  If there's some problem with the jack detection
being left enabled over suspend then that might need to be addressed in
the CODEC driver, but probably the machine driver shouldn't be doing
what it is.  

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)