linux-kernel - Re: [PATCH 4/5] scsi: ufs: pltfrm: Drop PM runtime reference count after ufshcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcd0182870d9e8056584b2aa99fb1c388885d5db.camel@mediatek.com>
Date: Tue, 12 Nov 2024 02:15:54 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "linkinjeon@...il.com" <linkinjeon@...il.com>, "orsonzhai@...il.com"
	<orsonzhai@...il.com>, "baolin.wang@...ux.alibaba.com"
	<baolin.wang@...ux.alibaba.com>, "yoshihiro.shimoda.uh@...esas.com"
	<yoshihiro.shimoda.uh@...esas.com>, "mikebi@...ron.com" <mikebi@...ron.com>,
	"krzk@...nel.org" <krzk@...nel.org>, "lporzio@...ron.com"
	<lporzio@...ron.com>, "linux@...ssschuh.net" <linux@...ssschuh.net>,
	"beanhuo@...ron.com" <beanhuo@...ron.com>, "avri.altman@....com"
	<avri.altman@....com>, "bvanassche@....org" <bvanassche@....org>,
	"zhang.lyra@...il.com" <zhang.lyra@...il.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "quic_asutoshd@...cinc.com"
	<quic_asutoshd@...cinc.com>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "chu.stanley@...il.com"
	<chu.stanley@...il.com>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "pedrom.sousa@...opsys.com"
	<pedrom.sousa@...opsys.com>, "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"santoshsy@...il.com" <santoshsy@...il.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 4/5] scsi: ufs: pltfrm: Drop PM runtime reference count
 after ufshcd_remove()

On Mon, 2024-11-11 at 23:18 +0530, Manivannan Sadhasivam via B4 Relay
wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> During the remove stage of glue drivers, some of them are
> incrementing the
> reference count using pm_runtime_get_sync(), before removing the
> ufshcd
> using ufshcd_remove(). But they are not dropping that reference count
> after
> ufshcd_remove() to balance the refcount.
> 
> So drop the reference count by calling pm_runtime_put_noidle() after
> ufshcd_remove(). Since the behavior is applicable to all glue
> drivers, move
> the PM handling to ufshcd_pltfrm_remove().
> 
> Cc: stable@...r.kernel.org # 3.12
> Fixes: 62694735ca95 ("[SCSI] ufs: Add runtime PM support for UFS host
> controller driver")
> Signed-off-by: Manivannan Sadhasivam <
> manivannan.sadhasivam@...aro.org>
> ---
>  drivers/ufs/host/tc-dwc-g210-pltfrm.c | 1 -
>  drivers/ufs/host/ufs-exynos.c         | 1 -
>  drivers/ufs/host/ufs-mediatek.c       | 1 -
>  drivers/ufs/host/ufs-qcom.c           | 1 -
>  drivers/ufs/host/ufs-sprd.c           | 1 -
>  drivers/ufs/host/ufshcd-pltfrm.c      | 2 ++
>  6 files changed, 2 insertions(+), 5 deletions(-)
> 
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>