linux-kernel - Re: [PATCH][next] platform/x86: hp: hp-bioscfg: remove redundant if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173143183902.3180.9868160429476963926.b4-ty@linux.intel.com>
Date: Tue, 12 Nov 2024 19:17:19 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Jorge Lopez <jorge.lopez2@...com>, Hans de Goede <hdegoede@...hat.com>, 
 platform-driver-x86@...r.kernel.org, 
 Colin Ian King <colin.i.king@...il.com>
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] platform/x86: hp: hp-bioscfg: remove redundant
 if statement

On Thu, 07 Nov 2024 11:35:43 +0000, Colin Ian King wrote:

> The if statement performs the same action if the strcmp result is
> true or false since there is identical code on both branches. The
> if statement is redundant and can be replaced with just one call
> to sysfs_remove_group.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: hp: hp-bioscfg: remove redundant if statement
      commit: 4ceb681f1822819f78b747ddc189479fead43be2

--
 i.