[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241112155817.3512577-1-snovitoll@gmail.com>
Date: Tue, 12 Nov 2024 20:58:09 +0500
From: Sabyrzhan Tasbolatov <snovitoll@...il.com>
To: gregkh@...uxfoundation.org,
andreyknvl@...il.com,
b-liu@...com,
johan@...nel.org,
oneukum@...e.com,
stern@...land.harvard.edu
Cc: linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org,
snovitoll@...il.com,
usb-storage@...ts.one-eyed-alien.net
Subject: [PATCH v2 0/8] drivers/usb: refactor min/max with min_t/max_t
This patch series improves type safety in the drivers/usb/*
by using `min_t()` and `max_t()` instead of min(), max()
with the casting inside. It should address potential type promotion issues.
Scanned the current drivers/usb code with `max\(.*\(` and `min\(.*\(`
regexp queries to find casting inside of min() and max() which
may lead to subtle bugs or even security vulnerabilities,
especially if negative values are involved.
Let's refactor to min_t() and max_t() specifying the data type
to ensure it's applicable for the both compareable arguments.
Changes v1 -> v2:
- split a single patch into a patch series
per each drivers/usb/* subdirectory (Greg).
Sabyrzhan Tasbolatov (8):
drivers/usb/gadget: refactor min with min_t
drivers/usb/core: refactor max with max_t
drivers/usb/host: refactor min/max with min_t/max_t
drivers/usb/misc: refactor min with min_t
drivers/usb/mon: refactor min with min_t
drivers/usb/musb: refactor min/max with min_t/max_t
drivers/usb/serial: refactor min with min_t
drivers/usb/storage: refactor min with min_t
drivers/usb/core/config.c | 2 +-
drivers/usb/gadget/composite.c | 12 ++++++------
drivers/usb/gadget/configfs.c | 2 +-
drivers/usb/gadget/function/f_fs.c | 6 +++---
drivers/usb/gadget/function/f_mass_storage.c | 8 ++++----
drivers/usb/gadget/function/uvc_video.c | 4 ++--
drivers/usb/gadget/legacy/raw_gadget.c | 4 ++--
drivers/usb/gadget/udc/omap_udc.c | 4 ++--
drivers/usb/gadget/usbstring.c | 2 +-
drivers/usb/host/ehci-hcd.c | 2 +-
drivers/usb/host/oxu210hp-hcd.c | 4 ++--
drivers/usb/host/r8a66597-hcd.c | 2 +-
drivers/usb/misc/usbtest.c | 3 ++-
drivers/usb/mon/mon_bin.c | 2 +-
drivers/usb/musb/musb_core.c | 2 +-
drivers/usb/musb/musb_gadget_ep0.c | 2 +-
drivers/usb/musb/musb_host.c | 5 ++---
drivers/usb/serial/io_edgeport.c | 2 +-
drivers/usb/serial/sierra.c | 2 +-
drivers/usb/storage/sddr09.c | 4 ++--
drivers/usb/storage/sddr55.c | 8 ++++----
21 files changed, 41 insertions(+), 41 deletions(-)
--
2.34.1
Powered by blists - more mailing lists