linux-kernel - Re: [PATCH] Remove unused function parameter in __smc_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241112182218.GV4507@kernel.org>
Date: Tue, 12 Nov 2024 18:22:18 +0000
From: Simon Horman <horms@...nel.org>
To: Wenjia Zhang <wenjia@...ux.ibm.com>
Cc: Manas <manas18244@...td.ac.in>, Jan Karcher <jaka@...ux.ibm.com>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Anup Sharma <anupnewsmail@...il.com>,
	linux-s390@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove unused function parameter in __smc_diag_dump

On Tue, Nov 12, 2024 at 08:36:13AM +0100, Wenjia Zhang wrote:
> 
> 
> On 11.11.24 16:10, Manas wrote:
> > On 11.11.2024 15:11, Wenjia Zhang wrote:

...

> > Thank you Wenjia for reviewing this.
> > 
> > Should I make any changes to the commit message if we are going forward
> > with it
> > being as a cleanup patch? The commit message itself (barring the cover
> > letter)
> > should be enough, I reckon.
> > 
> I think it is ok as it is.

Yes, agreed.

The commit message should be truncated at first scissors ("---").
Which leaves us with a commit message only describing the removal
of an unused function parameter. Which, given the discussion in
this thread, is what we want.

Reviewed-by: Simon Horman <horms@...nel.org>

> 
> Thanks,
> Wenjia
>