linux-kernel - Re: [PATCH] [v2] printk: add dummy printk_force_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57190fd1401fb6238e4e1efd078c3aaa0314ebac.camel@suse.com>
Date: Tue, 12 Nov 2024 16:02:53 -0300
From: Marcos Paulo de Souza <mpdesouza@...e.com>
To: Arnd Bergmann <arnd@...nel.org>, Petr Mladek <pmladek@...e.com>, John
 Ogness <john.ogness@...utronix.de>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>
Cc: Arnd Bergmann <arnd@...db.de>, Steven Rostedt <rostedt@...dmis.org>, 
 Sergey Senozhatsky <senozhatsky@...omium.org>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Sebastian Andrzej Siewior
 <bigeasy@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] printk: add dummy printk_force_console_enter/exit
 helpers

On Tue, 2024-11-12 at 15:29 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added interface is broken when PRINTK is disabled:
> 
> drivers/tty/sysrq.c: In function '__handle_sysrq':
> drivers/tty/sysrq.c:601:9: error: implicit declaration of function
> 'printk_force_console_enter' [-Wimplicit-function-declaration]
>   601 |         printk_force_console_enter();
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/tty/sysrq.c:611:25: error: implicit declaration of function
> 'printk_force_console_exit' [-Wimplicit-function-declaration]
>   611 |                         printk_force_console_exit();
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Add empty stub functions for both.

Ouch, indeed, my fault. After disabling prinkt I saw the build errors.
Thanks for fixing it!

Reviewed-by: Marcos Paulo de Souza <mpdesouza@...e.com>
Tested-by: Marcos Paulo de Souza <mpdesouza@...e.com>

> 
> Fixes: ed76c07c6885 ("printk: Introduce FORCE_CON flag")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v2: realized I sent the wrong version that was missing 'inline'.
> ---
>  include/linux/printk.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index 232e5fd06701..4217a9f412b2 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -232,6 +232,14 @@ static inline void printk_deferred_exit(void)
>  {
>  }
>  
> +static inline void printk_force_console_enter(void)
> +{
> +}
> +
> +static inline void printk_force_console_exit(void)
> +{
> +}
> +
>  static inline int printk_ratelimit(void)
>  {
>  	return 0;