linux-kernel - Re: [PATCH] of: Allow overlay kunit tests to run CONFIG_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b6d74e31161c8fadad926fe1c20ce1d.sboyd@kernel.org>
Date: Tue, 12 Nov 2024 11:50:48 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>, Rob Herring <robh@...nel.org>
Cc: Saravana Kannan <saravanak@...gle.com>, linux-kernel@...r.kernel.org, patches@...ts.linux.dev, devicetree@...r.kernel.org, kunit-dev@...glegroups.com
Subject: Re: [PATCH] of: Allow overlay kunit tests to run CONFIG_OF_OVERLAY=n

Quoting Rob Herring (2024-11-08 08:55:32)
> On Fri, Nov 08, 2024 at 09:56:15AM +0100, Geert Uytterhoeven wrote:
> > > > > Fixes: 5c9dd72d8385 ("of: Add a KUnit test for overlays and test managed APIs")
> > > >
> > > > Doesn't really seem like a fix.
> > >
> > > Ok. Feel free to drop the tag.
> > >
> > > > Does this need to go into 6.12?
> > >
> > > It's only important for 6.12 if kernel configurators want to build the
> > > kernel with OF_OVERLAY_KUNIT_TEST enabled and not be forced to enable
> > > CONFIG_OF_OVERLAY. I don't mind if it waits a while.
> > 
> > I'd say it's a fix, so please keep at last the Fixes tag. Merely
> > enabling kunit tests (which can be modular) should not increase the
> > possible attack vector on a product by enabling extra unneeded code.
> 
> Not sure I buy that that is an actual problem. However, not worth 
> arguing over. I only really care because if there's a Fixes, then this 
> really should go to Linus for 6.12 rather than eventually get 
> auto-selected from 6.13 to go to stable. So I moved it to send to Linus, 
> but I found that CONFIG_OF_OVERLAY is still selected with this patch. 
> That's because the clock kunit tests also select CONFIG_OF_OVERLAY. 
> That's fixed in next, but it's not queued up for 6.12.
> 

I was planning to send the clk patch in the next merge window. Are you
sending the fix now? If you want you can also send the clk side patch
and I can drop it from the clk tree.