linux-kernel - Re: [PATCH v6 2/3] x86: probe memory block size advisement value during mm init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6733c9d135589_10bc6294b6@dwillia2-xfh.jf.intel.com.notmuch>
Date: Tue, 12 Nov 2024 13:34:09 -0800
From: Dan Williams <dan.j.williams@...el.com>
To: Gregory Price <gourry@...rry.net>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	<linux-mm@...ck.org>
CC: <linux-cxl@...r.kernel.org>, <kernel-team@...a.com>,
	<Jonathan.Cameron@...wei.com>, <dan.j.williams@...el.com>,
	<rrichter@....com>, <Terry.Bowman@....com>, <dave.jiang@...el.com>,
	<ira.weiny@...el.com>, <alison.schofield@...el.com>, <gourry@...rry.net>,
	<dave.hansen@...ux.intel.com>, <luto@...nel.org>, <peterz@...radead.org>,
	<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>, <hpa@...or.com>,
	<rafael@...nel.org>, <lenb@...nel.org>, <david@...hat.com>,
	<osalvador@...e.de>, <gregkh@...uxfoundation.org>,
	<akpm@...ux-foundation.org>, <rppt@...nel.org>
Subject: Re: [PATCH v6 2/3] x86: probe memory block size advisement value
 during mm init

Gregory Price wrote:
> Systems with hotplug may provide an advisement value on what the
> memblock size should be.  Probe this value when the rest of the
> configuration values are considered.
> 
> The new heuristic is as follows
> 
> 1) set_memory_block_size_order value if already set (cmdline param)
> 2) minimum block size if memory is less than large block limit
> 3) if no hotplug advice: Max block size if system is bare-metal,
>    otherwise use end of memory alignment.
> 4) if hotplug advice: lesser of advice and end of memory alignment.

This seems like documentation that also belongs in-line in the code.
Perhaps a follow-on to add this to memory_block_advised_max_size()?
For this one:

Acked-by: Dan Williams <dan.j.williams@...el.com>