linux-kernel - Re: [PATCH v18 12/17] fprobe: Add fprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241113084325.86ce3d6bb44e7d67f5008825@kernel.org>
Date: Wed, 13 Nov 2024 08:43:25 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Florent Revest
 <revest@...omium.org>, linux-trace-kernel@...r.kernel.org, LKML
 <linux-kernel@...r.kernel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
 bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Jiri Olsa
 <jolsa@...nel.org>, Alan Maguire <alan.maguire@...cle.com>, Mark Rutland
 <mark.rutland@....com>, linux-arch@...r.kernel.org, Catalin Marinas
 <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Huacai Chen
 <chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
 <aou@...s.berkeley.edu>, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik
 <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>, Christian
 Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle
 <svens@...ux.ibm.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
 <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
 <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin"
 <hpa@...or.com>, Arnd Bergmann <arnd@...db.de>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH v18 12/17] fprobe: Add fprobe_header encoding feature

On Tue, 12 Nov 2024 09:44:37 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Sun, 10 Nov 2024 00:10:54 +0900
> Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:
> 
> > > > +++ b/arch/x86/include/asm/fprobe.h
> > > > @@ -0,0 +1,9 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > > +#ifndef _ASM_X86_FPROBE_H
> > > > +#define _ASM_X86_FPROBE_H
> > > > +
> > > > +#ifdef CONFIG_64BIT
> > > > +#include <asm-generic/fprobe.h>
> > > > +#endif
> > > > +
> > > > +#endif /* _ASM_X86_FPROBE_H */
> > > > \ No newline at end of file  
> > > 
> > > Same for the above.  
> > 
> > OK, but x86 and riscv, we need this default template on 64bit only.
> > So those may keep it, right?
> 
> Hmm, I wonder if we could just add:
> 
>   generic-$(CONFIG_X86_32)
> 
> But since I don't see that used anywhere, we may need this for archs that
> partially have it.

Since this mask is not available on 32bit (since 32-4 = 28bit is 256MB,
which is too small for kernel space), I checked CONFIG_64BIT in 
asm-generic header in v19. So now I can use generic-y for most
architecture.

Thank you,

> 
> -- Steve

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>