linux-kernel - Re: [PATCH net-next v3 2/2] eth: fbnic: Add devlink dev flash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241111191931.284b1be4@kernel.org>
Date: Mon, 11 Nov 2024 19:19:31 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Lee Trager <lee@...ger.us>
Cc: Alexander Duyck <alexanderduyck@...com>, kernel-team@...a.com, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jonathan Corbet
 <corbet@....net>, Andrew Lunn <andrew+netdev@...n.ch>, Sanman Pradhan
 <sanmanpradhan@...a.com>, Al Viro <viro@...iv.linux.org.uk>, Mohsin Bashir
 <mohsin.bashr@...il.com>, Kalesh AP <kalesh-anakkur.purayil@...adcom.com>,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] eth: fbnic: Add devlink dev flash
 support

Please drop Al Viro from the CC (!?) and CC the maintainer of the pldm
library (Jake).

On Sun, 10 Nov 2024 20:28:42 -0800 Lee Trager wrote:
> +/**
> + * fbnic_send_package_data - Send record package data to firmware
> + * @context: PLDM FW update structure
> + * @data: pointer to the package data
> + * @length: length of the package data
> + *
> + * Send a copy of the package data associated with the PLDM record matching
> + * this device to the firmware.
> + *
> + * Return: zero on success
> + *	    negative error code on failure
> + */

can we drop these kdocs please? In the bast case they just repeat 
the function name ("send package data") 3 times, in the worst case they
are misleading. This function sends absolutely nothing to the firmware.

> +static int fbnic_send_package_data(struct pldmfw *context, const u8 *data,
> +				   u16 length)
> +{
> +	struct device *dev = context->dev;
> +
> +	/* Temp placeholder required by devlink */

Do you mean that the pldm lib requires this callback to exist?
If yes then make it not require it if it's not necessary?

> +	dev_info(dev,
> +		 "Sending %u bytes of PLDM record package data to firmware\n",
> +		 length);

Please drop all the dev_*() prints. If something is important enough to
be reported it should be reported via the devlink info channel, to the
user. Not to system logs.

> +	return 0;
> +}
-- 
pw-bot: cr