linux-kernel - Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7661b9f9-c301-4eb9-9764-db8b24ad0c08@gmail.com>
Date: Tue, 12 Nov 2024 07:42:03 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Rob Herring <robh@...nel.org>, lee@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, sre@...nel.org
Subject: Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm
 instead of MOhm

On 11/11/2024 12:31, Andreas Kemnade wrote:
> Am Mon, 4 Nov 2024 08:06:53 +0200
> schrieb Matti Vaittinen <mazziesaccount@...il.com>:
> 
>> On 01/11/2024 21:27, Rob Herring wrote:
>>> On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:
>>>> Apparently there was some confusion regarding milliohm vs. megaohm.
>>>> (m/M). Use microohms to be able to properly specify the charger
>>>> resistor like other drivers do. This is not used yet by mainline code
>>>> yet. Specify a current sense resistor in milliohms range rathes then
>>>> megaohms range in the examples.
>>>
>>> milliohms?
>>>
>>> rathes?
>>>    
>>>>
>>>> CC: sre@...nel.org
>>>> Reported-by: Matti Vaittinen <mazziesaccount@...il.com>
>>>> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
>>>> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
>>>> ---
>>>>    .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
>>>>    1 file changed, 7 insertions(+), 6 deletions(-)
>>>
>>> Looks like rohm,bd71815-pmic.yaml has the same problem.
>>
>> Yes! Thanks for pointing it out. I'll wait for a while if Andreas wants
>> to fix them both at the same go. I'll send a fix for BD71815 if I've not
>> seen one in a week or so :)
>>
> There is more debris left from an apparently copy-paste-modify process
> from bd71828. That should be checked. At least there are several
> occurances of the BD71828 string in there. So a brush is needed.

Thanks for a heads-up Andreas. I'll take a look at it :)

Yours,
	-- Matti