linux-kernel - Re: [PATCHv2 net-next] net: use pdev instead of OF funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241112-lush-beneficial-chicken-9a31f5-mkl@pengutronix.de>
Date: Tue, 12 Nov 2024 08:55:00 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Vladimir Oltean <olteanv@...il.com>, Chen-Yu Tsai <wens@...e.org>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, 
	Pantelis Antoniou <pantelis.antoniou@...il.com>, Marcin Wojtas <marcin.s.wojtas@...il.com>, 
	Byungho An <bh74.an@...sung.com>, Kevin Brace <kevinbrace@...cecomputerlab.com>, 
	Francois Romieu <romieu@...zoreil.com>, Michal Simek <michal.simek@....com>, 
	Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, 
	Zhao Qiang <qiang.zhao@....com>, "open list:CAN NETWORK DRIVERS" <linux-can@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>, 
	"moderated list:ARM/Allwinner sunXi SoC support" <linux-arm-kernel@...ts.infradead.org>, 
	"open list:ARM/Allwinner sunXi SoC support" <linux-sunxi@...ts.linux.dev>, 
	"open list:FREESCALE SOC FS_ENET DRIVER" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCHv2 net-next] net: use pdev instead of OF funcs

On 11.11.2024 13:03:16, Rosen Penev wrote:
> np here is the node coming from platform_device. No children are used.
> 
> I changed irq_of_parse_and_map to platform_get_irq to pass it directly.
> 
> I changed of_address_to_resource to platform_get_resource for the same
> reason.
> 
> It ends up being the same.

You should describe in an imperative way your changes. Something like:

Modernize IRQ resource acquisition.

Replace irq_of_parse_and_map() by platform_get_irq()

...and list the other changes, too.

> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  v2: fixed compilation errors. Also removed non devm transformations.
>  Those will be handled separately. Also reworded description.
>  drivers/net/can/grcan.c                          |  2 +-
>  drivers/net/can/mscan/mpc5xxx_can.c              |  2 +-

Reviewed by: Marc Kleine-Budde <mkl@...gutronix.de> # for CAN

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)