linux-kernel - RE: [PATCH v1 04/22] HID: intel-thc-hid: intel-thc: Add THC PIO operation APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6098FA19368C76792457FD02F4592@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Tue, 12 Nov 2024 08:52:25 +0000
From: "Xu, Even" <even.xu@...el.com>
To: "Aaron, Ma" <aaron.ma@...onical.com>
CC: "bentiss@...nel.org" <bentiss@...nel.org>, "corbet@....net"
	<corbet@....net>, "jikos@...nel.org" <jikos@...nel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Zhang, Rui1"
	<rui1.zhang@...el.com>, "srinivas.pandruvada@...ux.intel.com"
	<srinivas.pandruvada@...ux.intel.com>, "Sun, Xinpeng" <xinpeng.sun@...el.com>
Subject: RE: [PATCH v1 04/22] HID: intel-thc-hid: intel-thc: Add THC PIO
 operation APIs

Hi, Aaron,

Yes, THC drivers can support multi-touch, we tested on Wacom touchscreen and Elan touchscreens.
In general, those are HID protocol related, if single touch can support, multi-touch should can be supported (If panel supports). 
Driver only transfers data and doesn't care data content.

Previously, I met a similar problem on a touchpad, after debugging, I found:
1. This touchpad exposes several HID collections: Mouse and TouchPad.
2. In order to benefit UEFI implementation, this touchpad FW will work as Mouse mode at beginning, so UEFI can easy use it.
3. After enter into Windows, Windows HID Class driver will set some special commands which cause touchpad FW switching to TouchPad mode.
4. But on Linux, Linux HID core doesn't have those special command, so this touchpad lives in Mouse mode on Linux OS, and only has single touch function.

Can you share me all the kernel log, then I can double check?
Thanks!

Best Regards,
Even Xu

> -----Original Message-----
> From: Aaron Ma <aaron.ma@...onical.com>
> Sent: Tuesday, November 12, 2024 3:16 PM
> To: Xu, Even <even.xu@...el.com>
> Cc: bentiss@...nel.org; corbet@....net; jikos@...nel.org; linux-
> doc@...r.kernel.org; linux-kernel@...r.kernel.org; Zhang, Rui1
> <rui1.zhang@...el.com>; srinivas.pandruvada@...ux.intel.com; Sun, Xinpeng
> <xinpeng.sun@...el.com>
> Subject: Re: [PATCH v1 04/22] HID: intel-thc-hid: intel-thc: Add THC PIO operation
> APIs
> 
> Hi Even,
> 
> After tested on 8086:a848, the multitouch doesn't work like 4 finger touch,
> rotation and zoom.
> 
> Could help check if those features can be supported?
> 
> Regards,
> Aaron
> 
> 
> On 11/11/24 3:10 PM, Xu, Even wrote:
> > Hi, Aaron,
> >
> > That's OK. Glad to know it works.
> > Thanks for testing!
> >
> > Best Regards,
> > Even Xu
> >
> >> -----Original Message-----
> >> From: Aaron Ma <aaron.ma@...onical.com>
> >> Sent: Monday, November 11, 2024 3:08 PM
> >> To: Xu, Even <even.xu@...el.com>
> >> Cc: bentiss@...nel.org; corbet@....net; jikos@...nel.org; linux-
> >> doc@...r.kernel.org; linux-kernel@...r.kernel.org; Zhang, Rui1
> >> <rui1.zhang@...el.com>; srinivas.pandruvada@...ux.intel.com; Sun,
> >> Xinpeng <xinpeng.sun@...el.com>
> >> Subject: Re: [PATCH v1 04/22] HID: intel-thc-hid: intel-thc: Add THC
> >> PIO operation APIs
> >>
> >> Hi Even,
> >>
> >> Sorry, my fault.
> >>
> >> The patchset is applied on 6.12-rc7.
> >> Building, will let you know the test result.
> >>
> >> Thanks.
> >> Aaron
> >>
> >> On 11/11/24 2:31 PM, Xu, Even wrote:
> >>> Hi, Aaron,
> >>>
> >>> Thanks for the information.
> >>> The file "intel-thc-hw.h" should be there, it was added by "[PATCH
> >>> v1 03/22]
> >> HID: intel-thc-hid: intel-thc: Add THC registers definition".
> >>> I tested it on v6.11.
> >>> Anyway, let me double check what's wrong and come back to you.
> >>> Thanks!
> >>>
> >>> Best Regards,
> >>> Even Xu
> >>>
> >>>> -----Original Message-----
> >>>> From: Aaron Ma <aaron.ma@...onical.com>
> >>>> Sent: Monday, November 11, 2024 2:19 PM
> >>>> To: Xu, Even <even.xu@...el.com>
> >>>> Cc: bentiss@...nel.org; corbet@....net; jikos@...nel.org; linux-
> >>>> doc@...r.kernel.org; linux-input@...r.kernel.or;
> >>>> linux-kernel@...r.kernel.org; Zhang, Rui1 <rui1.zhang@...el.com>;
> >>>> srinivas.pandruvada@...ux.intel.com; Sun, Xinpeng
> >>>> <xinpeng.sun@...el.com>
> >>>> Subject: Re: [PATCH v1 04/22] HID: intel-thc-hid: intel-thc: Add
> >>>> THC PIO operation APIs
> >>>>
> >>>> Hi Even,
> >>>>
> >>>> It fails to be applied on v6.12-rc7.
> >>>>
> >>>> There is no file intel-thc-hw.h.
> >>>>
> >>>> Regards,
> >>>> Aaron