linux-kernel - Re: [net-next v6 6/9] netdev-genl: Support setting per-NAPI config values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <719083c2-e277-447b-b6ea-ca3acb293a03@redhat.com>
Date: Tue, 12 Nov 2024 10:17:40 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Joe Damato <jdamato@...tly.com>, netdev@...r.kernel.org
Cc: mkarsten@...terloo.ca, skhawaja@...gle.com, sdf@...ichev.me,
 bjorn@...osinc.com, amritha.nambiar@...el.com, sridhar.samudrala@...el.com,
 willemdebruijn.kernel@...il.com, edumazet@...gle.com,
 Jakub Kicinski <kuba@...nel.org>, Donald Hunter <donald.hunter@...il.com>,
 "David S. Miller" <davem@...emloft.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 Mina Almasry <almasrymina@...gle.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [net-next v6 6/9] netdev-genl: Support setting per-NAPI config
 values

On 10/11/24 20:45, Joe Damato wrote:
> +int netdev_nl_napi_set_doit(struct sk_buff *skb, struct genl_info *info)
> +{
> +	struct napi_struct *napi;
> +	unsigned int napi_id;
> +	int err;
> +
> +	if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_NAPI_ID))
> +		return -EINVAL;
> +
> +	napi_id = nla_get_u32(info->attrs[NETDEV_A_NAPI_ID]);
> +
> +	rtnl_lock();
> +
> +	napi = napi_by_id(napi_id);

AFAICS the above causes a RCU splat in the selftests:

https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/856342/61-busy-poll-test-sh/stderr

because napi_by_id() only checks for the RCU lock.

Could you please have a look?

Thanks!

Paolo