linux-kernel - Re: [PATCH] clk: amlogic: axg-audio: fix Kconfig dependency on RESET_MESON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1jmsi42492.fsf@starbuckisacylon.baylibre.com>
Date: Tue, 12 Nov 2024 10:25:13 +0100
From: Jerome Brunet <jbrunet@...libre.com>
To: Arnd Bergmann <arnd@...nel.org>, Stephen Boyd <sboyd@...nel.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,  Michael Turquette
 <mturquette@...libre.com>,  Kevin Hilman <khilman@...libre.com>,  Arnd
 Bergmann <arnd@...db.de>,  Martin Blumenstingl
 <martin.blumenstingl@...glemail.com>,  Chuan Liu <chuan.liu@...ogic.com>,
  Xianwei Zhao <xianwei.zhao@...ogic.com>,
  linux-amlogic@...ts.infradead.org,  linux-clk@...r.kernel.org,
  linux-arm-kernel@...ts.infradead.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: amlogic: axg-audio: fix Kconfig dependency on
 RESET_MESON_AUX

On Mon 11 Nov 2024 at 11:29, Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> As in most cases, using 'imply' is wrong here and does not prevent
> build failures since that code may not be visible to a built-in
> clk driver:
>
> axg-audio.c:(.text+0x15c): undefined reference to `devm_meson_rst_aux_register'

The function registering the aux driver was in clock in some old version
(imply was ok at that point) and I forgot to change that when it moved to
reset.

Thanks for catching this
Reviewed-by: Jerome Brunet <jbrunet@...libre.com>

Stephen, This fixes the PR you applied. I guess how to pick this up
depends on how you want to deal with the Fixes tag problem reported by
Stephen Rothwell.

>
> Replace the incorrt 'imply' with the necessary 'depends on'.
>
> Fixes: 664988eb47dd ("clk: amlogic: axg-audio: use the auxiliary reset driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/clk/meson/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index 7cb21fc223b0..febb5d7348ff 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -106,7 +106,7 @@ config COMMON_CLK_AXG_AUDIO
>  	select COMMON_CLK_MESON_SCLK_DIV
>  	select COMMON_CLK_MESON_CLKC_UTILS
>  	select REGMAP_MMIO
> -	imply RESET_MESON_AUX
> +	depends on RESET_MESON_AUX
>  	help
>  	  Support for the audio clock controller on AmLogic A113D devices,
>  	  aka axg, Say Y if you want audio subsystem to work.

-- 
Jerome