linux-kernel - Re: [PATCH v2 2/2] tools: ynl: extend CFLAGS to keep options from environment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2o72ku75g.fsf@gmail.com>
Date: Tue, 12 Nov 2024 09:35:07 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Jan Stancek <jstancek@...hat.com>
Cc: kuba@...nel.org,  pabeni@...hat.com,  davem@...emloft.net,
  edumazet@...gle.com,  horms@...nel.org,  netdev@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] tools: ynl: extend CFLAGS to keep options from
 environment

Jan Stancek <jstancek@...hat.com> writes:

> Package build environments like Fedora rpmbuild introduced hardening
> options (e.g. -pie -Wl,-z,now) by passing a -spec option to CFLAGS
> and LDFLAGS.
>
> ynl Makefiles currently override CFLAGS but not LDFLAGS, which leads
> to a mismatch and build failure:
>         CC sample devlink
>   /usr/bin/ld: devlink.o: relocation R_X86_64_32 against symbol `ynl_devlink_family' can not be used when making a PIE object; recompile with -fPIE
>   /usr/bin/ld: failed to set dynamic section sizes: bad value
>   collect2: error: ld returned 1 exit status
>
> Extend CFLAGS to support hardening options set by build environment.
>
> Signed-off-by: Jan Stancek <jstancek@...hat.com>
> Acked-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>