linux-kernel - Re: [PATCH] firmware: Switch back to struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024111223-gizzard-scabby-eb98@gregkh>
Date: Tue, 12 Nov 2024 12:39:32 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Sudeep Holla <sudeep.holla@....com>,
	Cristian Marussi <cristian.marussi@....com>,
	Tzung-Bi Shih <tzungbi@...nel.org>,
	Brian Norris <briannorris@...omium.org>,
	Julius Werner <jwerner@...omium.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Conor Dooley <conor.dooley@...rochip.com>,
	Daire McNamara <daire.mcnamara@...rochip.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Gabriel Somlo <somlo@....edu>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Dinh Nguyen <dinguyen@...nel.org>,
	Michal Simek <michal.simek@....com>,
	Stefan Wahren <wahrenst@....net>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Jay Buddhabhatti <jay.buddhabhatti@....com>,
	Ronak Jain <ronak.jain@....com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
	Praveen Teja Kundanala <praveen.teja.kundanala@....com>,
	arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
	imx@...ts.linux.dev, linux-riscv@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, qemu-devel@...gnu.org,
	linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] firmware: Switch back to struct platform_driver::remove()

On Tue, Nov 12, 2024 at 09:35:20AM +0100, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
> 
> Convert all platform drivers below drivers/firmware to use .remove(),
> with the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Hello,
> 
> I did a single patch for all of drivers/firmware. While I usually prefer
> to do one logical change per patch, this seems to be overengineering
> here as the individual changes are really trivial and shouldn't be much
> in the way for stable backports.
> 
> There is no dedicated maintainer for drivers/firmware, maybe Sudeep as
> biggest committer there can take it? Or would it be sensible to split
> this patch?

I'll just take it now, thanks!

greg k-h