linux-kernel - Re: [RESEND PATCH v4 2/2] mtd: spi-nor: support vcc-supply regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mafs0r07g7ggf.fsf@kernel.org>
Date: Tue, 12 Nov 2024 13:02:40 +0000
From: Pratyush Yadav <pratyush@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Pratyush Yadav <pratyush@...nel.org>,  peng.fan@....nxp.com,
  m.felsch@...gutronix.de,  mwalle@...nel.org,  miquel.raynal@...tlin.com,
  richard@....at,  vigneshr@...com,  robh@...nel.org,  krzk+dt@...nel.org,
  conor+dt@...nel.org,  shawnguo@...nel.org,  s.hauer@...gutronix.de,
  kernel@...gutronix.de,  festevam@...il.com,
  linux-mtd@...ts.infradead.org,  devicetree@...r.kernel.org,
  linux-kernel@...r.kernel.org,  imx@...ts.linux.dev,
  linux-arm-kernel@...ts.infradead.org,  Peng Fan <peng.fan@....com>
Subject: Re: [RESEND PATCH v4 2/2] mtd: spi-nor: support vcc-supply regulator

On Tue, Nov 12 2024, Tudor Ambarus wrote:

> On 11/11/24 2:02 PM, Pratyush Yadav wrote:
>> On Tue, Oct 29 2024, Tudor Ambarus wrote:
>> 
>>> From: Peng Fan <peng.fan@....com>
>>>
>>> SPI NOR flashes needs power supply to work properly. The power supply
>>> maybe software controllable per board design. So add the support
>>> for an vcc-supply regulator.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@....com>
>>> Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>
>>> [ta: move devm_regulator_get_enable() to spi_nor_probe(). Add local dev
>>> variable to avoid dereferences.]
>>> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
>> 
>> Reviewed-by: Pratyush Yadav <pratyush@...nel.org>
>> 
>
> thanks, Pratyush. I sent a v5 here, where I introduce the temporary
> variable to struct device in its dedicated patch. Would you mind adding
> the R-b tag there?
> https://lore.kernel.org/linux-mtd/20241111111946.9048-1-tudor.ambarus@linaro.org/

Ah, I missed that in the many emails in by mailbox. Will take a look.

>
> btw, I try to keep patchwork in sync, so you can see the status of
> patches there as well:
>
> https://patchwork.ozlabs.org/project/linux-mtd/list/?series=&submitter=&state=&q=spi-nor&archive=&delegate=
>
> Thanks!

-- 
Regards,
Pratyush Yadav