linux-kernel - Re: [PATCH] fs:aio: Remove TODO comment suggesting hash or array usage in io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241112-begierde-skepsis-34f013abaa1f@brauner>
Date: Tue, 12 Nov 2024 14:13:39 +0100
From: Christian Brauner <brauner@...nel.org>
To: Mohammed Anees <pvmohammedanees2003@...il.com>
Cc: Christian Brauner <brauner@...nel.org>,
	linux-aio@...ck.org,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	jmoyer@...hat.com,
	bcrl@...ck.org,
	jack@...e.cz,
	viro@...iv.linux.org.uk,
	willy@...radead.org
Subject: Re: [PATCH] fs:aio: Remove TODO comment suggesting hash or array usage in io_cancel()

On Tue, 12 Nov 2024 17:08:34 +0530, Mohammed Anees wrote:
> The comment suggests a hash or array approach to
> store the active requests. Currently it iterates
> through all the active requests and when found
> deletes the requested request, in the linked list.
> However io_cancel() isn’t a frequently used operation,
> and optimizing it wouldn’t bring a substantial benefit
> to real users and the increased complexity of maintaining
> a hashtable for this would be significant and will slow
> down other operation. Therefore remove this TODO
> to avoid people spending time improving this.
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs:aio: Remove TODO comment suggesting hash or array usage in io_cancel()
      https://git.kernel.org/vfs/vfs/c/27e4f4fa65c2