linux-kernel - Re: [PATCH v2 1/2] spi: imx: pass struct spi_transfer to prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzTFcD+GQ9a443G0@lizhi-Precision-Tower-5810>
Date: Wed, 13 Nov 2024 10:27:44 -0500
From: Frank Li <Frank.li@....com>
To: Jonas Rebmann <jre@...gutronix.de>
Cc: Mark Brown <broonie@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, kernel@...gutronix.de,
	linux-spi@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] spi: imx: pass struct spi_transfer to
 prepare_transfer()

On Wed, Nov 13, 2024 at 01:18:31PM +0100, Jonas Rebmann wrote:
> In an upcoming patch, mx51_ecspi_prepare_transfer() needs access to the
> word_delay parameter. To enable controller-specific handling of such
> per-transfer parameters, extend the prepare_transfer() function of the
> spi_imx_devtype_data interface to take a struct spi_transfer argument,
> update all controller-specific implementations accordingly.
>
> Signed-off-by: Jonas Rebmann <jre@...gutronix.dei

Reviewed-by: Frank Li <Frank.Li@....com>
> ---
>  drivers/spi/spi-imx.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 85bd1a82a34eb4bc76a4b4528e087fc2ebfa8b85..65a8303b80b1191cd2c19d61f88836e7fd3c7ae9 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -71,7 +71,8 @@ struct spi_imx_data;
>  struct spi_imx_devtype_data {
>  	void (*intctrl)(struct spi_imx_data *spi_imx, int enable);
>  	int (*prepare_message)(struct spi_imx_data *spi_imx, struct spi_message *msg);
> -	int (*prepare_transfer)(struct spi_imx_data *spi_imx, struct spi_device *spi);
> +	int (*prepare_transfer)(struct spi_imx_data *spi_imx, struct spi_device *spi,
> +				struct spi_transfer *t);
>  	void (*trigger)(struct spi_imx_data *spi_imx);
>  	int (*rx_available)(struct spi_imx_data *spi_imx);
>  	void (*reset)(struct spi_imx_data *spi_imx);
> @@ -649,7 +650,7 @@ static void mx51_configure_cpha(struct spi_imx_data *spi_imx,
>  }
>
>  static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
> -				       struct spi_device *spi)
> +				       struct spi_device *spi, struct spi_transfer *t)
>  {
>  	u32 ctrl = readl(spi_imx->base + MX51_ECSPI_CTRL);
>  	u32 clk;
> @@ -774,7 +775,7 @@ static int mx31_prepare_message(struct spi_imx_data *spi_imx,
>  }
>
>  static int mx31_prepare_transfer(struct spi_imx_data *spi_imx,
> -				 struct spi_device *spi)
> +				 struct spi_device *spi, struct spi_transfer *t)
>  {
>  	unsigned int reg = MX31_CSPICTRL_ENABLE | MX31_CSPICTRL_HOST;
>  	unsigned int clk;
> @@ -878,7 +879,7 @@ static int mx21_prepare_message(struct spi_imx_data *spi_imx,
>  }
>
>  static int mx21_prepare_transfer(struct spi_imx_data *spi_imx,
> -				 struct spi_device *spi)
> +				 struct spi_device *spi, struct spi_transfer *t)
>  {
>  	unsigned int reg = MX21_CSPICTRL_ENABLE | MX21_CSPICTRL_HOST;
>  	unsigned int max = is_imx27_cspi(spi_imx) ? 16 : 18;
> @@ -953,7 +954,7 @@ static int mx1_prepare_message(struct spi_imx_data *spi_imx,
>  }
>
>  static int mx1_prepare_transfer(struct spi_imx_data *spi_imx,
> -				struct spi_device *spi)
> +				struct spi_device *spi, struct spi_transfer *t)
>  {
>  	unsigned int reg = MX1_CSPICTRL_ENABLE | MX1_CSPICTRL_HOST;
>  	unsigned int clk;
> @@ -1304,7 +1305,7 @@ static int spi_imx_setupxfer(struct spi_device *spi,
>  		spi_imx->target_burst = t->len;
>  	}
>
> -	spi_imx->devtype_data->prepare_transfer(spi_imx, spi);
> +	spi_imx->devtype_data->prepare_transfer(spi_imx, spi, t);
>
>  	return 0;
>  }
>
> --
> 2.39.5
>