linux-kernel - Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6454497ff35d2a534cd34b7635fb044e4033fe6b@vahedi.org>
Date: Wed, 13 Nov 2024 02:11:54 +0000
From: "Shahab Vahedi" <list+bpf@...edi.org>
To: "Vadim Fedorenko" <vadim.fedorenko@...ux.dev>, "Hardevsinh Palaniya"
 <hardevsinh.palaniya@...iconsignals.io>, ast@...nel.org,
 andrii@...nel.org
Cc: "Daniel Borkmann" <daniel@...earbox.net>, "Martin KaFai Lau"
 <martin.lau@...ux.dev>, "Eduard Zingerman" <eddyz87@...il.com>, "Song
 Liu" <song@...nel.org>, "Yonghong Song" <yonghong.song@...ux.dev>, "John
 Fastabend" <john.fastabend@...il.com>, "KP Singh" <kpsingh@...nel.org>,
 "Stanislav Fomichev" <sdf@...ichev.me>, "Hao Luo" <haoluo@...gle.com>,
 "Jiri Olsa" <jolsa@...nel.org>, "Vineet Gupta" <vgupta@...nel.org>,
 bpf@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check

Vadim Fedorenko wrote:
 
> The original code is obviously optimized out, but the intention, I
> believe, was to check if the jump is conditional or not.
> So the proper fix should change the code to check cond:
> 
> - if (ARC_CC_AL)
> + if (cond == ARC_CC_AL)

That is absolutely correct. If a new patch is not submitted soon
I'll try to fix it myself.

Cheers,
Shahab