| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241113152442.4000468-1-aleksander.lobakin@intel.com>
Date: Wed, 13 Nov 2024 16:24:23 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
Toke Høiland-Jørgensen <toke@...hat.com>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
John Fastabend <john.fastabend@...il.com>,
Andrii Nakryiko <andrii@...nel.org>,
Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
Stanislav Fomichev <sdf@...ichev.me>,
Magnus Karlsson <magnus.karlsson@...el.com>,
nex.sw.ncis.osdt.itp.upstreaming@...el.com,
bpf@...r.kernel.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH net-next v5 00/19] xdp: a fistful of generic changes (+libeth_xdp)
XDP for idpf is currently 5 chapters:
* convert Rx to libeth;
* convert Tx and stats to libeth;
* generic XDP and XSk code changes (this);
* actual XDP for idpf via libeth_xdp;
* XSk for idpf (^).
Part III does the following:
* does some cleanups with marking read-only bpf_prog and xdp_buff
arguments const for some generic functions;
* allows attaching already registered XDP memory model to Rxq info;
* allows mixing pages from several Page Pools within one XDP frame;
* optimizes &xdp_frame structure and removes no-more-used field;
* adds generic functions to build skbs from xdp_buffs (regular and
XSk) and attach frags to xdp_buffs (regular and XSk);
* adds helper to optimize XSk xmit in drivers;
* extends libeth Rx to support XDP requirements (headroom etc.) on Rx;
* adds libeth_xdp -- libeth module with common XDP and XSk routines.
They are implemented mostly as inlines with inline callback arguments.
They will be then uninlined in the drivers with sane function sizes,
but without any indirect calls.
All those inlines and macros really removes tons of driver code, which
is mostly the same across the drivers minus HW-specific part. You just
basically need functions which read Rx descriptors and fill Tx
descriptors, call a couple macros and that's it. The rest is written
once in libeth_xdp.
All exception and cold code is external. Error handling etc, anything
that doesn't happen at line rates, is external. Only the hottest things
are inlined ensuring driver code doesn't bloat for no gain and that
cold code won't push hot code into more cachelines than wanted.
Note on diffstat: don't be scared, almost 1500 lines are documentation
explaining everything in details. The actual new code is around 2500.
Alexander Lobakin (18):
jump_label: export static_key_slow_{inc,dec}_cpuslocked()
skbuff: allow 2-4-argument skb_frag_dma_map()
unroll: add generic loop unroll helpers
bpf, xdp: constify some bpf_prog * function arguments
xdp, xsk: constify read-only arguments of some static inline helpers
xdp: allow attaching already registered memory model to xdp_rxq_info
page_pool: make page_pool_put_page_bulk() actually handle array of
pages
page_pool: allow mixing PPs within one bulk
xdp: get rid of xdp_frame::mem.id
xdp: add generic xdp_buff_add_frag()
xdp: add generic xdp_build_skb_from_buff()
xsk: align &xdp_buff_xsk harder
xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem_model()
xsk: make xsk_buff_add_frag really add a frag via
__xdp_buff_add_frag()
xsk: add generic XSk &xdp_buff -> skb conversion
xsk: add helper to get &xdp_desc's DMA and meta pointer in one go
libeth: support native XDP and register memory model
libeth: add a couple of XDP helpers (libeth_xdp)
Toke Høiland-Jørgensen (1):
xdp: register system page pool as an XDP memory model
drivers/net/ethernet/intel/libeth/Kconfig | 6 +
drivers/net/ethernet/intel/libeth/Makefile | 6 +
include/net/libeth/types.h | 102 +-
include/net/page_pool/types.h | 6 +-
drivers/net/ethernet/intel/libeth/priv.h | 37 +
include/linux/bpf.h | 12 +-
include/linux/filter.h | 9 +-
include/linux/netdevice.h | 7 +-
include/linux/skbuff.h | 49 +-
include/linux/unroll.h | 43 +
include/net/libeth/rx.h | 6 +-
include/net/libeth/tx.h | 34 +-
include/net/libeth/xdp.h | 1861 +++++++++++++++++
include/net/libeth/xsk.h | 684 ++++++
include/net/xdp.h | 185 +-
include/net/xdp_sock_drv.h | 52 +-
include/net/xsk_buff_pool.h | 12 +-
.../net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 30 +-
drivers/net/ethernet/intel/ice/ice_xsk.c | 32 +-
drivers/net/ethernet/intel/libeth/rx.c | 22 +-
drivers/net/ethernet/intel/libeth/tx.c | 39 +
drivers/net/ethernet/intel/libeth/xdp.c | 446 ++++
drivers/net/ethernet/intel/libeth/xsk.c | 264 +++
drivers/net/veth.c | 4 +-
kernel/bpf/cpumap.c | 2 +-
kernel/bpf/devmap.c | 8 +-
kernel/jump_label.c | 2 +
net/bpf/test_run.c | 4 +-
net/core/dev.c | 20 +-
net/core/filter.c | 41 +-
net/core/page_pool.c | 60 +-
net/core/skbuff.c | 2 +-
net/core/xdp.c | 311 ++-
net/xdp/xsk_buff_pool.c | 40 +
35 files changed, 4219 insertions(+), 221 deletions(-)
create mode 100644 drivers/net/ethernet/intel/libeth/priv.h
create mode 100644 include/net/libeth/xdp.h
create mode 100644 include/net/libeth/xsk.h
create mode 100644 drivers/net/ethernet/intel/libeth/tx.c
create mode 100644 drivers/net/ethernet/intel/libeth/xdp.c
create mode 100644 drivers/net/ethernet/intel/libeth/xsk.c
---
>From v4[0]:
* 12: pick RB from Toke;
* 19: drop redundant ';'s (Jakub);
* 19: fix a couple context imbalance warnings by moving __acquires() /
__releases() to the proper place (smatch);
* no functional changes.
>From v3[1]:
* rebase on top of the latest net-next to solve conflict (Jakub);
* 09: use iterative approach instead of recursive to not blow the stack
(Toke);
* 12: rephrase the commitmsg since the functionality changed, so that
it's not actual anymore (Toke);
* align &xdp_buff_xsk a bit harder since its alignment degraded
recently;
* pick RBs from Toke.
>From v2[2]:
* cover: rename the series;
* collect RBs and Acks from Maciej;
* 007: reword the commitmsg;
* 011: fix typos in the commitmsg (M);
* 012: 'ts' -> 'tsize' (M; not 'truesize' to fit into 80 cols =\);
* 016: fix the intro sentence (M);
* no functional changes.
>From v1[3]:
* rebase on top of the latest net-next;
* no other changes.
[0] https://lore.kernel.org/netdev/20241107161026.2903044-1-aleksander.lobakin@intel.com
[1] https://lore.kernel.org/netdev/20241030165201.442301-1-aleksander.lobakin@intel.com
[2] https://lore.kernel.org/netdev/20241015145350.4077765-1-aleksander.lobakin@intel.com
[3] https://lore.kernel.org/netdev/20241009152756.3113697-1-aleksander.lobakin@intel.com
--
2.47.0
Powered by blists - more mailing lists