linux-kernel - Re: [PATCH v2 2/2] rcuscale: Remove redundant WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5d6114c-b03f-4faa-b210-c7090e20afa6@amd.com>
Date: Wed, 13 Nov 2024 22:30:35 +0530
From: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
To: "Uladzislau Rezki (Sony)" <urezki@...il.com>,
 Frederic Weisbecker <frederic@...nel.org>
Cc: "Paul E . McKenney" <paulmck@...nel.org>, RCU <rcu@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>, Boqun Feng <boqun.feng@...il.com>,
 Joel Fernandes <joel@...lfernandes.org>,
 Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH v2 2/2] rcuscale: Remove redundant WARN_ON_ONCE() splat

On 11/13/2024 4:30 PM, Uladzislau Rezki (Sony) wrote:
> There are two places where WARN_ON_ONCE() is called two times
> in the error paths. One which is encapsulated into if() condition
> and another one, which is unnecessary, is placed in the brackets.
> 
> Remove an extra WARN_ON_ONCE() splat which is in brackets.
> 
> Reviewed-by: Paul E. McKenney <paulmck@...nel.org>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>
> ---

Reviewed-by: Neeraj Upadhyay <Neeraj.Upadhyay@....com>

- Neeraj