linux-kernel - Re: [PATCH v5 1/5] dt-bindings: pinctrl: modify gpio-cells property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f41bc32-2579-490d-af1e-875a6d12c219@amlogic.com>
Date: Wed, 13 Nov 2024 10:23:32 +0800
From: Xianwei Zhao <xianwei.zhao@...ogic.com>
To: neil.armstrong@...aro.org, Linus Walleij <linus.walleij@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Kevin Hilman <khilman@...libre.com>,
 Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: pinctrl: modify gpio-cells property

Hi Neil,
    Thanks for your advice.

On 2024/11/12 21:26, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi,
> 
> On 12/11/2024 11:26, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@...ogic.com>
>>
>> Extend the value range of #gpio-cells property, including [2, 3],
>> to compatible with Amlogic A4 SoC and later chips's pinctrl module.
>> The early GPIO parameter number is 2, and the later GPIO parameter
>> number is 3.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>
>> ---
>>   
>> .../devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml       | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml
>> index e707c222a07f..6b53577dea59 100644
>> --- 
>> a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml
>> +++ 
>> b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-common.yaml
>> @@ -36,7 +36,7 @@ $defs:
>>         gpio-controller: true
>>
>>         "#gpio-cells":
>> -        const: 2
>> +        enum: [2, 3]
>>
>>         gpio-ranges:
>>           maxItems: 1
>>
> 
> This is not what I expected, this allows 3 cells for all Amlogic pinctrl,
> which is wrong.
> 
> Instead, remove "#gpio-cells" definition from 
> amlogic,meson-pinctrl-common.yaml
> and add them in all amlogic,meson-pinctrl-XXX.yaml with const: 2, and 
> then when you
> introduce A4/A5, add a new amlogic,meson-pinctrl-a5.yaml with const: 3.
> 
Got it. Will do.
> Neil