linux-kernel - Re: [PATCH v5 0/7] mm/mprotect: Fix dax puds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzToT6kkN0kkh-ww@x1n>
Date: Wed, 13 Nov 2024 12:56:31 -0500
From: Peter Xu <peterx@...hat.com>
To: David Hildenbrand <david@...hat.com>
Cc: Jann Horn <jannh@...gle.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, "Kirill A . Shutemov" <kirill@...temov.name>,
	Nicholas Piggin <npiggin@...il.com>,
	Matthew Wilcox <willy@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	James Houghton <jthoughton@...gle.com>,
	Huang Ying <ying.huang@...el.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Rick P Edgecombe <rick.p.edgecombe@...el.com>,
	Hugh Dickins <hughd@...gle.com>, Borislav Petkov <bp@...en8.de>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Michael Ellerman <mpe@...erman.id.au>,
	Rik van Riel <riel@...riel.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Mel Gorman <mgorman@...hsingularity.net>, x86@...nel.org,
	Ingo Molnar <mingo@...hat.com>, linuxppc-dev@...ts.ozlabs.org,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Oscar Salvador <osalvador@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v5 0/7] mm/mprotect: Fix dax puds

On Wed, Nov 13, 2024 at 05:42:15PM +0100, David Hildenbrand wrote:
> On 13.11.24 17:39, Peter Xu wrote:
> > On Mon, Nov 11, 2024 at 10:20:59PM +0100, Jann Horn wrote:
> > > On Mon, Aug 12, 2024 at 8:12 PM Peter Xu <peterx@...hat.com> wrote:
> > > > Dax supports pud pages for a while, but mprotect on puds was missing since
> > > > the start.  This series tries to fix that by providing pud handling in
> > > > mprotect().  The goal is to add more types of pud mappings like hugetlb or
> > > > pfnmaps.  This series paves way for it by fixing known pud entries.
> > > 
> > > Do people actually use hardware where they can use PUD THP mappings
> > > for DAX? I thought that was just some esoteric feature that isn't
> > > actually usable on almost any system.
> > > Was I wrong about that?
> > 
> > I did run it with a qemu emulated nvdimm device.  Though in reality I've no
> > idea on how many people are using it..
> 
> I wonder if we still have to support it ... or could disable it+rip it out.

Note that in my previous email, I also mentioned mremap() for PMD on dax
too.  If that's a real problem, it won't be fixed even if dropping dax PUD
support.

And we definitely want to understand whether there're still users on pud
dax to consider dropping anything.. it could still be that both mprotect()
and mremap() are not yet used in the current use cases.

Thanks,

-- 
Peter Xu