linux-kernel - Re: [PATCH v2] scsi: ufs: core: Add ufshcd_send_bsg_uic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03dc2e67df8a26d204b457808329ee388715b67a.camel@gmail.com>
Date: Wed, 13 Nov 2024 19:21:23 +0100
From: Bean Huo <huobean@...il.com>
To: Ziqi Chen <quic_ziqichen@...cinc.com>, quic_asutoshd@...cinc.com, 
 quic_cang@...cinc.com, bvanassche@....org, mani@...nel.org,
 beanhuo@...ron.com,  avri.altman@....com, junwoo80.lee@...sung.com,
 martin.petersen@...cle.com,  quic_nguyenb@...cinc.com,
 quic_nitirawa@...cinc.com, quic_rampraka@...cinc.com
Cc: linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>, 
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Damien Le
 Moal <dlemoal@...nel.org>, Hannes Reinecke <hare@...e.de>, Peter Wang
 <peter.wang@...iatek.com>, Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>, Andrew Halaney <ahalaney@...hat.com>, 
 Maramaina Naresh <quic_mnaresh@...cinc.com>, open list
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: core: Add ufshcd_send_bsg_uic_cmd() for
 UFS BSG

On Wed, 2024-11-13 at 19:14 +0800, Ziqi Chen wrote:
> User layer applications can send UIC GET/SET commands via the BSG
> framework, and if the user layer application sends a UIC SET command
> to the PA_PWRMODE attribute, a power mode change shall be initiated
> in UniPro and two interrupts shall be triggered if the power mode is
> successfully changed, i.e., UIC Command Completion interrupt and UIC
> Power Mode interrupt.
> 
> The current UFS BSG code calls ufshcd_send_uic_cmd() directly, with
> which the second interrupt, i.e., UIC Power Mode interrupt, shall be
> treated as unhandled interrupt. In addition, after the UIC command is
> completed, user layer application has to poll UniPro and/or M-PHY
> state
> machine to confirm the power mode change is finished.
> 
> Add a new wrapper function ufshcd_send_bsg_uic_cmd() and call it from
> ufs_bsg_request() so that if a UIC SET command is targeting the
> PA_PWRMODE
> attribute it can be redirected to ufshcd_uic_pwr_ctrl().
> 
> Signed-off-by: Can Guo <quic_cang@...cinc.com>
> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>

Mabye this should be a bug fix.

Reviewed-by: Bean Huo <beanhuo@...ron.com>