linux-kernel - Re: [PATCH v10] iio: adc: pac1921: Add ACPI support to Microchip pac1921

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcj=vX2GNQRGPfB2rGod2VrWby942tpdws4GkObba+1GQ@mail.gmail.com>
Date: Wed, 13 Nov 2024 22:05:55 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: victor.duicu@...rochip.com
Cc: matteomartelli3@...il.com, jic23@...nel.org, lars@...afoo.de, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	marius.cristea@...rochip.com
Subject: Re: [PATCH v10] iio: adc: pac1921: Add ACPI support to Microchip pac1921

On Wed, Nov 13, 2024 at 1:48 PM <victor.duicu@...rochip.com> wrote:
>
> From: Victor Duicu <victor.duicu@...rochip.com>
>
> This patch implements ACPI support to Microchip pac1921.
> The driver can read the shunt resistor value and label from the ACPI table.
>
> Signed-off-by: Victor Duicu <victor.duicu@...rochip.com>

...

> Differences related to previous versions:
> v10:
> - fix coding style mistakes.
> - add UL to PAC1921_MAX_SHUNT_VALUE_uOHMS.
> - edit comment in pac1921_write_shunt_resistor.
> - in pac1921_probe use is_acpi_device_node instead of
>   ACPI_HANDLE.

Any explanation why my tag was not included? Haven't you addressed all
the things I pointed out? If not, care to elaborate why?

-- 
With Best Regards,
Andy Shevchenko